git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] error out if path is invalid

From
Johannes Sixt <j.sixt@viscovery.net>
Date
Oct 6, 2008, 07:02 UTC
Message-ID
<48E9B7FE.2000503@viscovery.net>
In-Reply-To
<1223172881-4948-2-git-send-email-dpotapov@gmail.com>
Dmitry Potapov schrieb:
>  	if (!verify_path(path))
> -		return -1;
> +		return error("Invalid path '%s'", path);

Look at this change. Didn't the code error out before, too? Same in the other cases. Hence, your patch subject does not describe the patch. And I'd appreciate if you could at least show an example in the description what the patch fixes.

-- Hannes
Previous: Dmitry PotapovNext: Dmitry Potapov
Message 4 of 7 in “make prefix_path() never return NULL”
  1. make prefix_path() never return NULLDmitry Potapov, Oct 5, 2008
  2. do not segfault if make_cache_entry failedDmitry Potapov, Oct 5, 2008
  3. error out if path is invalidDmitry Potapov, Oct 5, 2008
  4. Johannes SixtOct 6, 2008
  5. Dmitry PotapovOct 7, 2008
  6. Johannes SixtOct 7, 2008
  7. print an error message for invalid pathDmitry Potapov, Oct 11, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.