From: Johannes Sixt Date: Mon, 06 Oct 2008 07:02:22 GMT Subject: Re: [PATCH] error out if path is invalid Message-ID: <48E9B7FE.2000503@viscovery.net> In-Reply-To: <1223172881-4948-2-git-send-email-dpotapov@gmail.com> Dmitry Potapov schrieb: > if (!verify_path(path)) > - return -1; > + return error("Invalid path '%s'", path); Look at this change. Didn't the code error out before, too? Same in the other cases. Hence, your patch subject does not describe the patch. And I'd appreciate if you could at least show an example in the description what the patch fixes. -- Hannes