Re: [PATCH v2] Git.pm: Use File::Temp->tempfile instead of ->new

From: Tom G. Christensen <tgc@statsbiblioteket.dk>
Date: Sep 10, 2008, 07:16 UTC
Message-ID: <48C7745F.1070008@statsbiblioteket.dk>
In-Reply-To: <48C6B886.7020108@griep.us>

Marcus Griep wrote:

Show 20 quoted lines

> Tom G. Christensen wrote:
>> The testsuite now passes t9100-git-svn-basic.sh and instead fails at
>> t9108-git-svn-glob.sh but this appears to be unrelated to the File::Temp
>> issue.
>>
>> --- expect.three        2008-09-09 07:34:39.000000000 +0000
>> +++ stderr.three        2008-09-09 07:34:42.000000000 +0000
>> @@ -1,2 +1,3 @@
>> +Parentheses missing around "my" list at
>> /home/tgc/projects/git/t/../git-svn line 4429.
>>  Only one set of wildcard directories (e.g. '*' or '*/*/*') is
>> supported: 'branches/*/t/*'
>>
>> * FAIL 3: test disallow multi-globs
> 
> It's probably another back-portability issue (It's not failing in my testsuite).
> However, I think that I know the offending line.  Can you give me the text of
> your line 4429 in git-svn and I'll submit a separate patch to fix that back
> portability issue.
>

git-svn:4429:
         pipe my $rfd, my $wfd or return;

I know next to nothing about perl but I put () around my, my and then the test passes.

However it now fails in t9700/test.pl: t9700 $ ./test.pl -i -v ok 1 - use Git; Bareword "STDERR" not allowed while "strict subs" in use at ./test.pl line 38. Execution of ./test.pl aborted due to compilation errors. 1..1 # Looks like your test died just after 1.

Brandon Casey already posted a patch for this that also fixes the use of File::Temp->New in t9700/test.pl: http://article.gmane.org/gmane.comp.version-control.git/92791 Applying it allowed a full a run of the testsuite to complete without error.

'/bin/sh' ./aggregate-results.sh test-results/t*-* fixed 1 success 3709 failed 0 broken 2 total 3712

-tgc