git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git-svn: Fixes my() parameter list syntax error in pre-5.8 Perl

From
Marcus Griep <marcus@griep.us>
Date
Sep 10, 2008, 15:09 UTC
Message-ID
<1221059386-3972-1-git-send-email-marcus@griep.us>
In-Reply-To
<48C7745F.1070008@statsbiblioteket.dk>
---
 Per Tom G. Christensen's commentary on a breaking test in git-svn.
 git-svn.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-svn.perl b/git-svn.perl
index ecacf74..a97e1ca 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -4425,7 +4425,7 @@ sub config_pager {
 
 sub run_pager {
 	return unless -t *STDOUT && defined $pager;
-	pipe my $rfd, my $wfd or return;
+	pipe my ($rfd, $wfd) or return;
 	defined(my $pid = fork) or ::fatal "Can't fork: $!";
 	if (!$pid) {
 		open STDOUT, '>&', $wfd or
-- 
1.6.0.1.415.g7bb82
Previous: Tom G. ChristensenNext: Marcus Griep
Message 21 of 23 in “Git 1.6.0.1 breaks git-svn with perl 5.8.0”
  1. Tom G. ChristensenSep 1, 2008
  2. Matthieu MoySep 1, 2008
  3. Git.pm: Require File::Temp 0.14 for new()Abhijit Menon-Sen, Sep 1, 2008
  4. Tom G. ChristensenSep 1, 2008
  5. Git.pm: Use File::Temp->tempfile instead of ->newAbhijit Menon-Sen, Sep 1, 2008
  6. Tom G. ChristensenSep 1, 2008
  7. Junio C HamanoSep 7, 2008
  8. Abhijit Menon-SenSep 7, 2008
  9. Marcus GriepSep 7, 2008
  10. Abhijit Menon-SenSep 8, 2008
  11. Git.pm: Use File::Temp->tempfile instead of ->newMarcus Griep, Sep 8, 2008
  12. Git.pm: Use File::Temp->tempfile instead of ->newMarcus Griep, Sep 8, 2008
  13. Eric WongSep 9, 2008
  14. Junio C HamanoSep 10, 2008
  15. Eric WongSep 10, 2008
  16. Abhijit Menon-SenSep 9, 2008
  17. Marcus GriepSep 9, 2008
  18. Tom G. ChristensenSep 9, 2008
  19. Marcus GriepSep 9, 2008
  20. Tom G. ChristensenSep 10, 2008
  21. git-svn: Fixes my() parameter list syntax error in pre-5.8 PerlMarcus Griep, Sep 10, 2008
  22. Marcus GriepSep 10, 2008
  23. Tom G. ChristensenSep 1, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.