Re: git apply vs. renamed files index mismatch

From: Scott Wood <scottwood@freescale.com>
Date: Sep 8, 2008, 21:38 UTC
Message-ID: <48C59B71.3040902@freescale.com>
In-Reply-To: <20080908212717.GA21338@oksana.dev.rtsoft.ru>

Anton Vorontsov wrote:

> I always thought that posting "-M" patches to the public lists is
> discouraged since it is quite difficult to apply them via patch(1).
> Also think of non-git users...

I think the substantially enhanced reviewability trumps non-git-users who can follow the rename instructions manually (or fix up their patch utility) if they insist on shunning tools that would make their life easier.

Show 9 quoted lines

> diff --git a/arch/powerpc/kernel/dma.c b/arch/powerpc/kernel/dma.c
> new file mode 100644
> index 0000000..ae5708e
> [...]
> diff --git a/arch/powerpc/kernel/dma_64.c b/arch/powerpc/kernel/dma_64.c
> deleted file mode 100644
> index ae5708e..0000000
> 
> That is, if hashes match then it was pure rename.

I suppose, though it's not as easy to spot, and won't help in showing what the differences are if there are any.

-Scott