Re: [JGIT PATCH 1/2] Ignore unreadable SSH private keys when autoloading identities

From: Marek Zawirski <marek.zawirski@gmail.com>
Date: Aug 27, 2008, 23:26 UTC
Message-ID: <48B5E2A1.3030007@gmail.com>
In-Reply-To: <1219878126-18622-1-git-send-email-spearce@spearce.org>

Shawn O. Pearce wrote:

> diff --git a/org.spearce.jgit/src/org/spearce/jgit/transport/DefaultSshSessionFactory.java b/org.spearce.jgit/src/org/spearce/jgit/transport/DefaultSshSessionFactory.java

(...)

Show 7 quoted lines

> +			try {
> +				addIdentity(k);
> +			} catch (JSchException e) {
> +				if (e.getMessage().startsWith("invalid privatekey: "))
> +					continue;
> +				throw e;
> +			}

That's extreme error handling with JSch;) Do you really think it's better to rely on internal error message instead of continuing in any case? Which other exceptions we would like to pass level up?

-- 
Marek Zawirski [zawir]
marek.zawirski@gmail.com