git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fix a warning (on cygwin) to allow -Werror

From
Johannes Sixt <j.sixt@viscovery.net>
Date
Aug 27, 2008, 07:57 UTC
Message-ID
<48B508F0.70402@viscovery.net>
In-Reply-To
<48B4426D.3090801@ramsay1.demon.co.uk>
Ramsay Jones schrieb:
> Also, I noticed that git_ntohl() is still defined in compat/mingw.h; is this
> still required?  It's not a problem, just curious! (I don't have mingw
> installed, so I can't test myself)

Yes, it's still needed. The reason is that on Windows ntohl() returns 'unsigned long', and then gcc warns about

sha1_file.c:700: warning: unsigned int format, u_long arg (arg 3)
git_ntohl() is the workaround.
-- Hannes
Previous: Ramsay JonesNext: Ramsay Jones
Message 2 of 4 in “Fix a warning (on cygwin) to allow -Werror”
  1. Fix a warning (on cygwin) to allow -WerrorRamsay Jones, Aug 26, 2008
  2. Johannes SixtAug 27, 2008
  3. Ramsay JonesAug 28, 2008
  4. Johannes SixtAug 29, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.