From: Johannes Sixt <j.sixt@viscovery.net>
Date: Wed, 27 Aug 2008 07:57:36 GMT
Subject: Re: [PATCH] Fix a warning (on cygwin) to allow -Werror
Message-ID: <48B508F0.70402@viscovery.net>
In-Reply-To: <48B4426D.3090801@ramsay1.demon.co.uk>

Ramsay Jones schrieb:
> Also, I noticed that git_ntohl() is still defined in compat/mingw.h; is this
> still required?  It's not a problem, just curious! (I don't have mingw
> installed, so I can't test myself)

Yes, it's still needed. The reason is that on Windows ntohl() returns
'unsigned long', and then gcc warns about

sha1_file.c:700: warning: unsigned int format, u_long arg (arg 3)

git_ntohl() is the workaround.

-- Hannes