git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [EGIT PATCH 00/31] Push GUI, GUI improvements, various jgit stuff

From
MZMarek Zawirski <marek.zawirski@gmail.com>
Date
Aug 20, 2008, 02:42 UTC
Message-ID
<48AB84A2.7010905@gmail.com>
In-Reply-To
<200808192121.30372.robin.rosenberg.lists@dewire.com>
Robin Rosenberg wrote:
Show 19 quoted lines
> tisdagen den 19 augusti 2008 19.59.31 skrev Shawn O. Pearce:
>> Marek Zawirski <marek.zawirski@gmail.com> wrote:
>>> Robin, Tor, I know that you were already contributing some graphics to
>>> egit. If someone of you would like to do some icon for push/fetch with
>>> pleasure, you are welcome. Otherwise I'll have to do some crappy icon
>>> instead ;) Another matter are checkboxes screenshots. I'm not sure
>>> about legality status of including them. Any ideas if/how we co use
>>> them or some another set that we can for sure?
>> So my office-mate suggests that the output of a program (in this
>> case the checkbox icon) isn't covered by the same copyright as the
>> program that created it.  So we may be OK. 
> It's not that simple. That obviously may be the case, but I'm certain
> it does not apply to individual well defined pieces of artwork (or text for
> that matter) included in the output. 
> 
>> Or we just use some 
>> other sort of icon for the checkbox.  Maybe Tor would be able to
>> come up with something useful here?
> Most annoying is that we'd need one (four) for each LAF supported.

Well, consider that they are even more of them. GTK+ has configurable themes (in my case it is delegation to QT with Plastik theme, where screenshot was made). I don't know about other platforms, but always having hyper-UI Mac OS X and Windows Vista may also have some customization options. No matter how icons we would prepare, always there will be somebody who can say that these icons are somehow inconsistent with his/her LAF.

So I think, it'd better to have this mentioned ugly code workaround just for Mac OS (only there flashing window is so annoying). Less people suffering.

Or as Shawn said, we can try to make our own funny icon for Force Update (red "F"-enabled and gray "F"-disabled?) that is equally (in)consistent for everybody.

>> Anyway, most of this series looks pretty good to me.  I found a
>> few other annoying bugs in JGit and EGit as a result of testing
>> this series, but they are unrelated to the series and have been
>> there all along.  So I may try to fix them in the coming weeks.

Nice testing then, as I have spend hours on testing UI tricks and haven't noticed more bugs;) Beside of some indexing problems in old API.

Show 5 quoted lines
>>>  55 files changed, 6471 insertions(+), 981 deletions(-)
>> Heh.  Been busy, hmm?  ;-)
> 
> The weather in and around the Baltic Sea has been horrible for much
> of August so far. Maybe that helped him. :)

I swear guys, I wasn't sailing for over 1 month;) Actually, I'm now leaving for few days, so I'm sending out just fixes for issues pointed out by Shawn and found by me in the mean time. I'll squash these patches with existing commits in push branch, as it is probably worth nothing to keep this in history.

Fetch UI and dynamic team menu entries for push and fetch (for configured remotes) are underway, I'll come back to them after coming back home.

BTW, as another developers are getting involved in jgit/egit coding, maybe we could use (update) some wiki page for marking who is working on some topic currently? Now it's not obvious for me, and as we're not so numerous it would be pity to waste our time and do some redundant stuff one day.

-- 
Marek Zawirski [zawir]
marek.zawirski@gmail.com
Previous: Robin RosenbergNext: Marek Zawirski
Message 38 of 62 in “Push GUI, GUI improvements, various jgit stuff”
  1. 00/31 Push GUI, GUI improvements, various jgit stuffMarek Zawirski, Aug 17, 2008
  2. 01/31 Fix Repository.mapObject() for missing objectsMarek Zawirski, Aug 17, 2008
  3. 02/31 Fix Repository isValidRefName() for empty namesMarek Zawirski, Aug 17, 2008
  4. 03/31 Fix Repository.resolve() to not throw runtime exceptionsMarek Zawirski, Aug 17, 2008
  5. 04/31 Document/fix Transport open method for specific caseMarek Zawirski, Aug 17, 2008
  6. 05/31 Fix RefSpec javadoc regarding spec expandingMarek Zawirski, Aug 17, 2008
  7. 06/31 Make wildcard checking public in RefSpecMarek Zawirski, Aug 17, 2008
  8. 07/31 Add openAll() and applyConfig() methods to TransportMarek Zawirski, Aug 17, 2008
  9. 08/31 Add dryRun option to Transport and console pushMarek Zawirski, Aug 17, 2008
  10. 09/31 Extract Transport findRemoteRefUpdatesFor() as static methodMarek Zawirski, Aug 17, 2008
  11. 10/31 Improve javadoc of Transport push()Marek Zawirski, Aug 17, 2008
  12. 11/31 Clean up exception issues in RemoteRefUpdateMarek Zawirski, Aug 17, 2008
  13. 12/31 Add another RemoteRefUpdate constructor, useful for 2-stage pushMarek Zawirski, Aug 17, 2008
  14. 13/31 Add getAllRemoteConfigs() to RemoteConfigMarek Zawirski, Aug 17, 2008
  15. 14/31 Add setFetchRefSpecs and setPushRefSpecs to RemoteConfigMarek Zawirski, Aug 17, 2008
  16. 15/31 Add simple abbreviate() method to ObjectIdMarek Zawirski, Aug 17, 2008
  17. 16/31 Remove debug/test console output from GitIndexMarek Zawirski, Aug 17, 2008
  18. 17/31 Fix typo in uitext.properties messageMarek Zawirski, Aug 17, 2008
  19. 18/31 Refactor/rewrite CloneSourcePage to universal RepositorySelectionPageMarek Zawirski, Aug 17, 2008
  20. 19/31 Clone wizard and related: refactor, clean-up, fixes or improvementsMarek Zawirski, Aug 17, 2008
  21. 20/31 Move clone logic away from GitCloneWizard to CloneOperationMarek Zawirski, Aug 17, 2008
  22. 21/31 Add canCreateSubdir() heuristic in CloneDestinationPageMarek Zawirski, Aug 17, 2008
  23. 22/31 Set FileDialog selection appropriately in clone wizardMarek Zawirski, Aug 17, 2008
  24. 23/31 Allow selecting empty dir in clone wizardMarek Zawirski, Aug 17, 2008
  25. 24/31 Clone wizard: force dir to suggested path only if repo selection changeMarek Zawirski, Aug 17, 2008
  26. 25/31 Create ListRemoteOperation for listing remote repo branchesMarek Zawirski, Aug 17, 2008
  27. 26/31 Make Clone's SourceBranchPage more user-friendlyMarek Zawirski, Aug 17, 2008
  28. 27/31 Add few EPL Eclipse iconsMarek Zawirski, Aug 17, 2008
  29. 28/31 Checkbox images/screenshotsMarek Zawirski, Aug 17, 2008
  30. 29/31 Universal GUI for specifications edition: RefSpecPanel and relatedMarek Zawirski, Aug 17, 2008
  31. 30/31 Add PushOperation to pluginMarek Zawirski, Aug 17, 2008
  32. 31/31 Push GUIMarek Zawirski, Aug 17, 2008
  33. Robin RosenbergAug 19, 2008
  34. Shawn O. PearceAug 19, 2008
  35. Shawn O. PearceAug 19, 2008
  36. Shawn O. PearceAug 19, 2008
  37. Robin RosenbergAug 19, 2008
  38. Marek ZawirskiAug 20, 2008
  39. 1/6 Remove DEFAULT_DRY_RUN constant from TransportMarek Zawirski, Aug 20, 2008
  40. 2/6 Emphasize that db is a local one in RemoteRefUpdateMarek Zawirski, Aug 20, 2008
  41. 3/6 Handle URIs parsing errors in PushAction betterMarek Zawirski, Aug 20, 2008
  42. 4/6 Fix proposal provider for fetch in RefSpecPanelMarek Zawirski, Aug 20, 2008
  43. 5/6 Fix disappearing "save configuration" label in RefSpecPageMarek Zawirski, Aug 20, 2008
  44. 6/6 Fix RefSpecPage formattingMarek Zawirski, Aug 20, 2008
  45. Shawn O. PearceAug 20, 2008
  46. Git-aware Issue Tracking?Petr Baudis, Aug 20, 2008
  47. Shawn O. PearceAug 20, 2008
  48. Robin RosenbergAug 20, 2008
  49. Martin LanghoffAug 21, 2008
  50. Jakub NarebskiAug 20, 2008
  51. Pierre HabouzitAug 21, 2008
  52. Jakub NarebskiAug 21, 2008
  53. Mike DalessioAug 20, 2008
  54. Imran M YousufAug 21, 2008
  55. Marek ZawirskiAug 25, 2008
  56. Shawn O. PearceAug 25, 2008
  57. Robin RosenbergAug 21, 2008
  58. Shawn O. PearceAug 21, 2008
  59. Robin RosenbergAug 21, 2008
  60. Shawn O. PearceAug 22, 2008
  61. Marek ZawirskiAug 25, 2008
  62. Shawn O. PearceAug 25, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.