Re: Re* git diff/log --check exitcode and PAGER environment variable
- From
- Peter Valdemar Mørch (Lists) <4ux6as402@sneakemail.com>
- Date
- Aug 8, 2008, 11:02 UTC
- Message-ID
- <489C27DD.90603@sneakemail.com>
- In-Reply-To
- <7v1w0zersg.fsf_-_@gitster.siamese.dyndns.org>
Junio C Hamano gitster-at-pobox.com |Lists| wrote:
Show 5 quoted lines
> --paginate:: > - Pipe all output into 'less' (or if set, $PAGER). > + Pipe all output into 'less' (or if set, $PAGER). Note that this > + implies that the exit code you see from the command will be that > + of the pager, not git.
Thank you for the attention, Junio.
I don't want to be a troll... But in my original post, I write that git log exits with 0 even when there are --check failures *and* --no-pager is used.
$ PAGER=cat git --no-pager log HEAD~20..HEAD --check --exit-code $ echo $? 0
Here I don't think the pager is involved, and so perhaps this is an unrelated issue.
Since the pager/exit code issue is going to be looked at post 1.6.0 herhaps this is low-priority: Nowhere in man git-diff does it mention the pager or less or that git-diff by default behaves as if -p/--paginate from "man git" had been given. I personally would not have thought to look there or caught the connection. But perhaps I'm bikeshedding.
If I'm percieved as trolling: Please let me know. This documentation string took time out of my day. (Less, though than this thread has! :D)
Peter
-- Peter Valdemar Mørch http://www.morch.com