Re: git diff/log --check exitcode and PAGER environment variable

From: Peter Valdemar Mørch (Lists) <4ux6as402@sneakemail.com>
Date: Aug 8, 2008, 10:04 UTC
Message-ID: <489C1A40.9000001@sneakemail.com>
In-Reply-To: <7vfxpfet8a.fsf@gitster.siamese.dyndns.org>

Junio C Hamano gitster-at-pobox.com |Lists| wrote:

Show 10 quoted lines

>> There is this old thread:
>> "[PATCH 1/5] "diff --check" should affect exit status"
>> http://thread.gmane.org/gmane.comp.version-control.git/68145/focus=68148
>> which seemed not to reach a conclusion.
> 
> Conclusion was (1) if you really care about the exit code, do not use
> pager; (2) after 1.6.0 we will swap the child/parent between git and pager
> to expose exit code from us, but not before.
> 
> Or am I mistaken?

Perhaps a more correct statement on my part would have been that I couldn't find the conclusion. :-)

It ended with Junio C Hamano saying:

> Heh, I am about to push out fixed-up results, so it might save both of
> us some time if you looked at it first and then complained on my
> screwups.

I wasn't subscribed to the list back then and couldn't follow beyond that thread in GMane.

Regardless of what happened or not back then, the current documentation does not match the current code. Not for git-diff, and certainly not for git-log.

Or am I mistaken?

I didn't see a reference in that thread to post 1.6.0 changes or to child/parent relationships, but if this is known and planned for post-1.6.0, then cool: I'll get on with my life and let you get on with yours!

Peter

-- 
Peter Valdemar Mørch
http://www.morch.com