Re: linking libgit.a in C++ projects

From: Boaz Harrosh <bharrosh@panasas.com>
Date: Jul 31, 2008, 13:04 UTC
Message-ID: <4891B872.3040707@panasas.com>
In-Reply-To: <ac9f0f090807310253v1d97e2a1n4ddf34aa4fdc79f0@mail.gmail.com>

cte wrote:

Show 12 quoted lines

> I'm writing a git gui for OS X using cocoa/Objective-C++, and rather
> than being lame and parsing the output the various git commands, I'm
> using libgit.a to provide all of the needed functionality for my app.
> However, the git source uses a few reserved C++ keywords; namely
> 'typename', and 'new'. So, I was wondering if it is worth submitting a
> patch to fix these issues... I'm asking because I'm new to the whole
> open source thing, and I don't want to get yelled at by the git
> maintainers for submitting stupid patches that no one in their right
> mind would accept :)
> 
> Thanks!
> --

The practice of avoiding C++ keywords from public C headers is very welcome. You should send a patch and try to push it.

That said the problem can be easily avoided.

Produce a C file and header that defines some stable API to your GUI application, that does not expose any git internal headers. Then compile that, say git_api.c, with C compiler in Makefile and extern "C" link that file to your C++ application. This will completely insulate you from any git code.

This could also solve the other problem of API changing, only the git_api.c need change, your outer GUI code stays the same.

And if you do all that maybe you can submit it for inclusion as a: somewhat stable high-level library, for developers. Ala git-dev

Cheers Boaz