git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitweb: fix support for repository directories with spaces

From
LWLea Wiemann <lewiemann@gmail.com>
Date
Jun 17, 2008, 22:07 UTC
Message-ID
<48583584.6030906@gmail.com>
In-Reply-To
<m3k5goon7v.fsf@localhost.localdomain>
Jakub Narebski wrote:
> I'd like to do away with need for git_cmd_str(), but unfortunately it
> is needed in a place where git has to form pipeline, namely in
> creating externally compressed snapshot (in git_snapshot), and to
> redirect stderr to /dev/null in git_object.

git_objects's use of 2> /dev/null won't be necessary since the Git::Repo API uses cat-file --batch-check, which doesn't (well, shouldn't) write on stderr.

If the use of shell command lines in git_snapshot bothers us enough, we can (a) create the pipe ourselves and just have it not work on Windows, (b) create it ourselves and spend a lot of time working around Windows' horribly borked API, or (c) use Perl's Zlib/Bzip2/LZO libraries. If anything I'm in favor of (c), though it makes installation harder if you want compressed tarballs. I'm fine with leaving it as is.

-- Lea
Previous: Jakub NarebskiNext: Jakub Narebski
Message 8 of 9 in “gitweb: fix support for repository directories with spaces”
  1. gitweb: fix support for repository directories with spacesLea Wiemann, Jun 17, 2008
  2. Junio C HamanoJun 17, 2008
  3. Junio C HamanoJun 17, 2008
  4. gitweb: quote commands properly when calling the shellLea Wiemann, Jun 17, 2008
  5. Lea WiemannJun 17, 2008
  6. Junio C HamanoJun 17, 2008
  7. Jakub NarebskiJun 17, 2008
  8. Lea WiemannJun 17, 2008
  9. Jakub NarebskiJun 17, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.