Re: [PATCH] gitweb: fix support for repository directories with spaces

From: Jakub Narebski <jnareb@gmail.com>
Date: Jun 17, 2008, 22:27 UTC
Message-ID: <200806180027.47810.jnareb@gmail.com>
In-Reply-To: <48583584.6030906@gmail.com>

Lea Wiemann wrote:

Show 9 quoted lines

> Jakub Narebski wrote:
> > I'd like to do away with need for git_cmd_str(), but unfortunately it
> > is needed in a place where git has to form pipeline, namely in
> > creating externally compressed snapshot (in git_snapshot), and to
> > redirect stderr to /dev/null in git_object.
> 
> git_objects's use of 2> /dev/null won't be necessary since the Git::Repo 
> API uses cat-file --batch-check, which doesn't (well, shouldn't) write 
> on stderr.

Even without Git::Repo using git-cat-file new '--batch-check' option would be good replacement.

Show 6 quoted lines

> If the use of shell command lines in git_snapshot bothers us enough, we 
> can (a) create the pipe ourselves and just have it not work on Windows, 
> (b) create it ourselves and spend a lot of time working around Windows' 
> horribly borked API, or (c) use Perl's Zlib/Bzip2/LZO libraries.  If 
> anything I'm in favor of (c), though it makes installation harder if you 
> want compressed tarballs.  I'm fine with leaving it as is.

Please remember that gitweb is to be installed also in tightly controlled server installations, where anything outside default packages, or extras package repository, or at least trusted contrib packages repository is out of the question. Installing from CPAN is not an option.

That is why I'd rather avoid dependencies on modules which are not distributed with Perl by default.

And there is another solution, (d) add gzip/bzip2 compression support to git-archive ;-P

-- 
Jakub Narebski
Poland