git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] gitweb: use Git.pm, and use its parse_rev method for git_get_head_hash

From
LWLea Wiemann <lewiemann@gmail.com>
Date
Jun 1, 2008, 15:44 UTC
Message-ID
<4842C3F1.5000001@gmail.com>
In-Reply-To
<7vzlq5bm32.fsf@gitster.siamese.dyndns.org>
Junio C Hamano wrote:
Show 5 quoted lines
> With this on top of your parse_rev patch (I used v2 but I do not think v3
> changes the situation in any way), you seem to have broken t9500.
> 
> [...] I suspect that you are not using your own Git in the build tree in
> your test, but an already installed one.
That was indeed the case, thanks for pointing it out!

However, after applying my two patches and your patch on a pristine current git.git clone, I still don't get an error, even though the Gitweb test uses the new Git.pm (which I tested it does). Care to send me your error message so I can track it down, or even upload your complete tree somewhere? Feel free to reply off-list or ping me on IRC.

> +++ b/t/t9500-gitweb-standalone-no-errors.sh
>  
> +	PERL5LIB=$(pwd)/../../perl/blib/lib

How about putting this into test-lib.sh? There are more tests (like my new Git.pm test suite) that will need it, so setting it up in a central place would probably more convenient and prevent future problems of this sort.

If PERL5LIB already contains paths, can we just discard them, or should we preserve them?

Since perl/Makefile only copies Git.pm to blib/lib/Git.pm, we could also set the path to ../../perl, which would prevent us from accidentally running tests against an old version of Git.pm (because we haven't run cd perl; make before). And perhaps add a comment to perl/Makefile about this, in case someone wants to change the build process in the future. Or is there some reason why this would be a bad idea?

-- Lea
Previous: Junio C HamanoNext: Junio C Hamano
Message 14 of 23 in “gitweb: use Git.pm, and use its parse_rev method for git_get_head_hash”
  1. gitweb: use Git.pm, and use its parse_rev method for git_get_head_hashLea Wiemann, May 30, 2008
  2. Lea WiemannMay 30, 2008
  3. Jakub NarebskiMay 31, 2008
  4. Lea WiemannMay 31, 2008
  5. Jakub NarebskiJun 1, 2008
  6. Junio C HamanoJun 2, 2008
  7. Petr BaudisJun 2, 2008
  8. Jakub NarebskiJun 2, 2008
  9. Lea WiemannJun 2, 2008
  10. Petr BaudisMay 31, 2008
  11. gitweb: use Git.pm, and use its parse_rev method for git_get_head_hashLea Wiemann, May 31, 2008
  12. Lea WiemannMay 31, 2008
  13. Junio C HamanoJun 1, 2008
  14. Lea WiemannJun 1, 2008
  15. Junio C HamanoJun 1, 2008
  16. test-lib.sh: set PERL5LIB instead of GITPERLLIBLea Wiemann, Jun 1, 2008
  17. Junio C HamanoJun 2, 2008
  18. Lea WiemannJun 2, 2008
  19. test-lib.sh: set PERL5LIB instead of GITPERLLIBLea Wiemann, Jun 2, 2008
  20. Junio C HamanoJun 2, 2008
  21. Lea WiemannJun 2, 2008
  22. Lea WiemannJun 3, 2008
  23. Lea WiemannJun 1, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.