Re: [PATCH] make commit --interactive lock index
- From
Paolo Bonzini <bonzini@gnu.org>
- Date
- May 29, 2008, 19:17 UTC
- Message-ID
- <483F012D.3060308@gnu.org>
- In-Reply-To
- <20080529185617.GC5596@steel.home>
Alex Riesen wrote:
Show 10 quoted lines
> Paolo Bonzini, Thu, May 29, 2008 20:00:55 +0200: >>>> The "if() die ()" thingie is already in builtin-commit.c, so we won't >>>> ever get a pathspec in the "add --interactive" case. If we do, >>>> something else has already been done incorrectly before -- not by the >>>> user but by the programmer. >>> What could that be? >> Nothing, but it documents to whoever reads the code what is the path >> that will be taken. Anyway if it happened it would be very bad. > > Why is a comment not enough?
I tend to use comment if it is more interesting to express the condition in English, and asserts if it is more interesting to express it as code.
Paolo