Re: [PATCH] make commit --interactive lock index
Paolo Bonzini, Thu, May 29, 2008 20:00:55 +0200:
Show 10 quoted lines
>
>>> The "if() die ()" thingie is already in builtin-commit.c, so we won't
>>> ever get a pathspec in the "add --interactive" case. If we do,
>>> something else has already been done incorrectly before -- not by the
>>> user but by the programmer.
>>
>> What could that be?
>
> Nothing, but it documents to whoever reads the code what is the path
> that will be taken. Anyway if it happened it would be very bad.
Why is a comment not enough?