git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] rollback index if git-commit is interrupted by a signal

From
Paolo Bonzini <bonzini@gnu.org>
Date
May 29, 2008, 14:35 UTC
Message-ID
<483EBF1F.9000809@gnu.org>
In-Reply-To
<alpine.DEB.1.00.0805291456030.13507@racer.site.net>
Show 7 quoted lines
>> Without this change, there could be races between the time the lock file 
>> is created and the time the commit_style variable is set, leading to the 
>> rollback not being performed.
> 
> IMO it would make much more sense to _guarantee_ that the commity_style 
> variable is set before the index is locked.  It is feasible, and there is 
> no good reason not to do that.

No, it's not possible because the COMMIT_PARTIAL case first creates the index_lock and then the false_lock. It would be curious at least to set the commit_style to COMMIT_NORMAL after creating the index_lock, and upgrade it to COMMIT_PARTIAL later on. I contemplated that, and my patch is the simplest code that's needed and works.

Paolo
Previous: Johannes SchindelinNext: Johannes Schindelin
Message 5 of 10 in “rollback index if git-commit is interrupted by a signal”
  1. rollback index if git-commit is interrupted by a signalPaolo Bonzini, May 29, 2008
  2. Johannes SchindelinMay 29, 2008
  3. Paolo BonziniMay 29, 2008
  4. Johannes SchindelinMay 29, 2008
  5. Paolo BonziniMay 29, 2008
  6. Johannes SchindelinMay 29, 2008
  7. rollback lock files on more signals than just SIGINTPaolo Bonzini, May 29, 2008
  8. Mike RalphsonJun 4, 2008
  9. Junio C HamanoJun 4, 2008
  10. Mike RalphsonJun 5, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.