git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitweb: only display "next" links in logs if there is a next page

From
LWLea Wiemann <lewiemann@gmail.com>
Date
May 28, 2008, 00:10 UTC
Message-ID
<483CA307.8040900@gmail.com>
In-Reply-To
<7v1w3nz43f.fsf@gitster.siamese.dyndns.org>
Junio C Hamano wrote:
> I do not trust people who rely on "tests" to catch counting errors

Oh, I wasn't trying to say that I didn't "brain-check" my code for correctness -- I just think it's a good idea to actually test it in addition to that. :)

Anyways, thanks for reviewing and confirming it!
> I wonder if it is easier to read to use the more modern @array notation
> than historic $#array notation (it looks very Perl 4 to me), but that is a
> separate issue.  gitweb is littered with such anachronism ;-)
Yup, I was trying to be consistent there.
-- Lea
Previous: Junio C HamanoNext: Jakub Narebski
Message 7 of 8 in “gitweb: only display "next" links in logs if there is a next page”
  1. gitweb: only display "next" links in logs if there is a next pageLea Wiemann, May 27, 2008
  2. Junio C HamanoMay 27, 2008
  3. Lea WiemannMay 27, 2008
  4. gitweb: only display "next" links in logs if there is a next pageLea Wiemann, May 27, 2008
  5. Lea WiemannMay 27, 2008
  6. Junio C HamanoMay 28, 2008
  7. Lea WiemannMay 28, 2008
  8. Jakub NarebskiMay 28, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.