git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitweb: only display "next" links in logs if there is a next page

From
LWLea Wiemann <lewiemann@gmail.com>
Date
May 27, 2008, 23:30 UTC
Message-ID
<483C99A2.90909@gmail.com>
In-Reply-To
<1211930742-24978-1-git-send-email-LeWiemann@gmail.com>
Lea Wiemann wrote:
> There was a bug in the implementation of the "next" links in
> format_paging_nav (for log and shortlog), which caused the next links
> to always be displayed, even if there is no next page.  This fixes it.

Oh, one more thing I forgot to mention: I've tested this with a small (single-page) log page and a long log page. In both cases the "next" links get formatted correctly, and they stop linking to the next page on the correct (= last) page. The only thing I haven't tested for is off-by-one errors, but I'm reasonably sure that $#commitlist >= 100 is right.

-- Lea
Previous: Lea WiemannNext: Junio C Hamano
Message 5 of 8 in “gitweb: only display "next" links in logs if there is a next page”
  1. gitweb: only display "next" links in logs if there is a next pageLea Wiemann, May 27, 2008
  2. Junio C HamanoMay 27, 2008
  3. Lea WiemannMay 27, 2008
  4. gitweb: only display "next" links in logs if there is a next pageLea Wiemann, May 27, 2008
  5. Lea WiemannMay 27, 2008
  6. Junio C HamanoMay 28, 2008
  7. Lea WiemannMay 28, 2008
  8. Jakub NarebskiMay 28, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.