git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/4] Implement normalize_absolute_path

From
DRDavid Reiss <dreiss@facebook.com>
Date
May 20, 2008, 16:44 UTC
Message-ID
<4832FFEA.7020905@facebook.com>
In-Reply-To
<alpine.DEB.1.00.0805201321300.30431@racer>
> I wonder why my advice to look at setup.c (I think I did not mention the
> function name "sanitary_path_copy()" in particular, because I figured you
> would spot it right away) went unheeded.
I wonder why my comment in the patch went unheeded:
> The closest thing I could find to this in the existing code base was
> sanitary_path_copy, but it does not remove trailing slashes.

Honestly, I found it quite daunting to try to track down all of the indirect callers of sanitary_path_copy and ensure that they would continue to work if I changed the behavior of a function that does not document what it is supposed to do. Frankly, it would be easier for me to just keep rebasing my patches and apply them to my local builds.

--David
Previous: Johannes SchindelinNext: Alex Riesen
Message 3 of 6 in “Implement normalize_absolute_path”
  1. 1/4 Implement normalize_absolute_pathDavid Reiss, May 20, 2008
  2. Johannes SchindelinMay 20, 2008
  3. David ReissMay 20, 2008
  4. Alex RiesenMay 20, 2008
  5. David ReissMay 21, 2008
  6. Alex RiesenMay 22, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.