From: David Reiss <dreiss@facebook.com>
Date: Tue, 20 May 2008 16:44:26 GMT
Subject: Re: [PATCH 1/4] Implement normalize_absolute_path
Message-ID: <4832FFEA.7020905@facebook.com>
In-Reply-To: <alpine.DEB.1.00.0805201321300.30431@racer>

> I wonder why my advice to look at setup.c (I think I did not mention the
> function name "sanitary_path_copy()" in particular, because I figured you
> would spot it right away) went unheeded.

I wonder why my comment in the patch went unheeded:
> The closest thing I could find to this in the existing code base was
> sanitary_path_copy, but it does not remove trailing slashes.

Honestly, I found it quite daunting to try to track down all of the
indirect callers of sanitary_path_copy and ensure that they would
continue to work if I changed the behavior of a function that does not
document what it is supposed to do.  Frankly, it would be easier for me
to just keep rebasing my patches and apply them to my local builds.

--David