Re: [PATCH] mktag.c: improve verification of tagger field and tests
- From
Brandon Casey <casey@nrlssc.navy.mil>
- Date
- Mar 26, 2008, 16:37 UTC
- Message-ID
- <47EA7BDA.9070109@nrlssc.navy.mil>
- In-Reply-To
- <47EA7927.9060201@nrlssc.navy.mil>
Brandon Casey wrote:
Show 8 quoted lines
> Carlos Rica wrote: >> On Wed, Mar 26, 2008 at 1:40 AM, Brandon Casey <casey@nrlssc.navy.mil> wrote: >>> Well, since I looked at this code and used it in filter-branch, I figured I >>> should fix the verification code for the tagger field (even though it's >>> probably dieing soon). >>> >>> I'm thinking this utility should be fairly strict about the format it accepts. >> Why not using git-tag to make tags in filter-branch?
I replied, and then I thought, maybe you didn't notice that patch I submitted for filter-branch.
So, to clarify, I am not using mktag at a user-level. i.e. I am not using it in a script that I supplied _to_ filter-branch. I added a call to it from _within_ filter-branch so that the "object" part of tag objects can be retained when filtering.
-brandon