git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] mktag.c: improve verification of tagger field and tests

From
CRCarlos Rica <jasampler@gmail.com>
Date
Mar 26, 2008, 11:21 UTC
Message-ID
<1b46aba20803260421t4db4987gc6fc8b2e556032e0@mail.gmail.com>
In-Reply-To
<47E99B98.1060506@nrlssc.navy.mil>
On Wed, Mar 26, 2008 at 1:40 AM, Brandon Casey <casey@nrlssc.navy.mil> wrote:
Show 5 quoted lines
>  Well, since I looked at this code and used it in filter-branch, I figured I
>  should fix the verification code for the tagger field (even though it's
>  probably dieing soon).
>
>  I'm thinking this utility should be fairly strict about the format it accepts.
Why not using git-tag to make tags in filter-branch?

git-mktag was used in git-tag.sh before convert it into builtin-tag.c, and I didn't know that anyone was using it.

I agree that, if this program exists and it is used, we should double-check the accepted format and data, so this patch is a good addition.

However, I think that we should progressively deprecate its use to avoid mantaining two different ways for creating tags, so you must have a very good reason to keep using this tool in a script...

Regards

-- Carlos

Previous: Brandon CaseyNext: Brandon Casey
Message 3 of 12 in “mktag.c: improve verification of tagger field and tests”
  1. mktag.c: improve verification of tagger field and testsBrandon Casey, Mar 26, 2008
  2. Brandon CaseyMar 26, 2008
  3. Carlos RicaMar 26, 2008
  4. Brandon CaseyMar 26, 2008
  5. Brandon CaseyMar 26, 2008
  6. Junio C HamanoMar 26, 2008
  7. Brandon CaseyMar 26, 2008
  8. mktag.c: improve verification of tagger field and testsBrandon Casey, Mar 27, 2008
  9. Junio C HamanoMar 31, 2008
  10. Brandon CaseyMar 31, 2008
  11. mktag.c: tweak validation of tagger field and adjust test scriptBrandon Casey, Mar 31, 2008
  12. Junio C HamanoApr 1, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.