git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [EGIT PATCH] Showing abbreviated commit hash of the versions in Compare editor.

From
RSRoger C. Soares <rogersoares@intelinet.com.br>
Date
Jan 12, 2008, 03:02 UTC
Message-ID
<47882DBB.2000308@intelinet.com.br>
In-Reply-To
<200801110046.41786.robin.rosenberg.lists@dewire.com>
Robin Rosenberg escreveu:
Show 6 quoted lines
> I pushed my doc-branch as pu, you can look at it. My intention is take a look again
> and then push it as master if there are no objections. Is it ok and good to flags 
> public stuff without javadoc as an error (tip pu commit)?
>
> The abbr commit patch is already pushed to master.
>

Looks good to me. You actually took some time to explain things, it will be usefull, thanks! If we really want to document all the public methods then I think it's nice to flag it's absence as an error. It would have made me document GitResourceNode.getContentIdentifier(), it's now one more comment for you to add before pushing to master ;)

[]s, Roger.

Previous: Robin RosenbergNext: Roger C. Soares
Message 5 of 9 in “Showing abbreviated commit hash of the versions in Compare editor.”
  1. Showing abbreviated commit hash of the versions in Compare editor.Roger C. Soares, Jan 8, 2008
  2. Robin RosenbergJan 8, 2008
  3. Roger C. SoaresJan 9, 2008
  4. Robin RosenbergJan 10, 2008
  5. Roger C. SoaresJan 12, 2008
  6. Roger C. SoaresJan 12, 2008
  7. Robin RosenbergJan 12, 2008
  8. Roger C. SoaresJan 13, 2008
  9. Robin RosenbergJan 13, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.