From: Roger C. Soares Date: Sat, 12 Jan 2008 03:02:19 GMT Subject: Re: [EGIT PATCH] Showing abbreviated commit hash of the versions in Compare editor. Message-ID: <47882DBB.2000308@intelinet.com.br> In-Reply-To: <200801110046.41786.robin.rosenberg.lists@dewire.com> Robin Rosenberg escreveu: > I pushed my doc-branch as pu, you can look at it. My intention is take a look again > and then push it as master if there are no objections. Is it ok and good to flags > public stuff without javadoc as an error (tip pu commit)? > > The abbr commit patch is already pushed to master. > Looks good to me. You actually took some time to explain things, it will be usefull, thanks! If we really want to document all the public methods then I think it's nice to flag it's absence as an error. It would have made me document GitResourceNode.getContentIdentifier(), it's now one more comment for you to add before pushing to master ;) []s, Roger.