Re: [EGIT PATCH] Showing commit info like the CVS plugin instead of tooltips.

From: Roger C. Soares <rogersoares@intelinet.com.br>
Date: Jan 9, 2008, 01:17 UTC
Message-ID: <4784209D.6080100@intelinet.com.br>
In-Reply-To: <200801082320.52548.robin.rosenberg.lists@dewire.com>

Hi Robin,

> Looks nice. We probably want this into preferences and I'd still like the tooltop as an option. I.e. when you turn off
> the other panes the tooltip should come back. What I'd really want is the "Press F2"-version, like the javadoc
> tooltips, but that requires some more work (I guess, maybe only a little is needed).
>

Showing the tooltips when you press F2 makes more sense to me. What I'm confortable to do now is to add another option in the history menu (after show revision comment) to show the tooltips. I can send a new patch with this.

For the search bar, I would like to make it visible by pressing ctrl-f when the history panel has the focus. So if I learn how to do it I can also do the F2 for the tooltips (low priority though).

Show 17 quoted lines

>> +	/* private */TextViewer revDetailTextViewer;
>> +	/* private */TextViewer revCommentTextViewer;
>> +	/* private */IAction toggleCommentWrapAction;
>> +	/* private */IAction toggleRevDetailAction;
>> +	/* private */IAction toggleRevCommentAction;
>>  
>> -	private Table table;
>> +	/* private */Table table;
>>  
>> -	private List<IFileRevision> fileRevisions;
>> +	/* private */List<IFileRevision> fileRevisions;
>>  
>> -	protected boolean hintShowDiffNow;
>> +	/* private */boolean hintShowDiffNow;
>>     
> Why? What's wrong plain private?
>

This is to improve performance and getting rid of the warning: Read access to enclosing field GitHistoryPage.appliedPatches is emulated by a synthetic accessor method. Increasing its visibility will improve your performance

[]s, Roger.