Re: [EGIT PATCH] Showing commit info like the CVS plugin instead of tooltips.

From: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
Date: Jan 8, 2008, 22:20 UTC
Message-ID: <200801082320.52548.robin.rosenberg.lists@dewire.com>
In-Reply-To: <200801072320.26987.rogersoares@intelinet.com.br>

tisdagen den 8 januari 2008 skrev du:

> Tooltips for the info were annoying, especially on MacOS where the tooltip center is your pointer location.
> It is now possible to copy&paste data.
> Like the CVS plugin, there's a menu to show/hide views. Thought it doesn't save in the preferences store for now.

Looks nice. We probably want this into preferences and I'd still like the tooltop as an option. I.e. when you turn off the other panes the tooltip should come back. What I'd really want is the "Press F2"-version, like the javadoc tooltips, but that requires some more work (I guess, maybe only a little is needed).

Show 14 quoted lines

> +	/* private */TextViewer revDetailTextViewer;
> +	/* private */TextViewer revCommentTextViewer;
> +	/* private */IAction toggleCommentWrapAction;
> +	/* private */IAction toggleRevDetailAction;
> +	/* private */IAction toggleRevCommentAction;
>  
> -	private Table table;
> +	/* private */Table table;
>  
> -	private List<IFileRevision> fileRevisions;
> +	/* private */List<IFileRevision> fileRevisions;
>  
> -	protected boolean hintShowDiffNow;
> +	/* private */boolean hintShowDiffNow;

Why? What's wrong plain private?

> \ No newline at end of file

There was trailing whitespace also, but I can fix such things easily. I'm erasing those on changed lines only, a change at the time at the moment instead of big ws fixes. In eclipse 3.3 there is an option to fix trailing spaces on save on changed lines only.

-- robin