git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Allow commit (and tag) messages to be edited when $EDITOR has arguments

From
Thomas Harning <harningt@gmail.com>
Date
Dec 16, 2007, 01:41 UTC
Message-ID
<47648261.1050505@gmail.com>
In-Reply-To
<20071216011201.GA10867@midwinter.com>
Steven Grimm wrote:
> Users who do EDITOR="/usr/bin/emacs -nw" or similar were left unable to
> edit commit messages once commit became a builtin, because the editor
> launch code assumed that $EDITOR was a single pathname.
>

I see one problem with this code... If you use quotes (single or double) then this will break it. I suppose this isn't a major issue usually, but if not fixed should be documented. One case that jumps out of my head is an executable path with spaces (quite stupid-and-ugly, but possible).

Previous: Johannes Schindelin
Message 5 of 5 in “Allow commit (and tag) messages to be edited when $EDITOR has arguments”
  1. Allow commit (and tag) messages to be edited when $EDITOR has argumentsSteven Grimm, Dec 16, 2007
  2. Johannes SchindelinDec 16, 2007
  3. Allow commit (and tag) messages to be edited when $EDITOR has argumentsSteven Grimm, Dec 16, 2007
  4. Johannes SchindelinDec 16, 2007
  5. Thomas HarningDec 16, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.