From: Thomas Harning <harningt@gmail.com>
Date: Sun, 16 Dec 2007 01:41:53 GMT
Subject: Re: [PATCH] Allow commit (and tag) messages to be edited when $EDITOR has arguments
Message-ID: <47648261.1050505@gmail.com>
In-Reply-To: <20071216011201.GA10867@midwinter.com>

Steven Grimm wrote:
> Users who do EDITOR="/usr/bin/emacs -nw" or similar were left unable to
> edit commit messages once commit became a builtin, because the editor
> launch code assumed that $EDITOR was a single pathname.
>   
I see one problem with this code...  If you use quotes (single or 
double) then this will break it.  I suppose this isn't a major issue 
usually, but if not fixed should be documented.  One case that jumps out 
of my head is an executable path with spaces (quite stupid-and-ugly, but 
possible).