git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Replace misleading message during interactive rebasing

From
Johannes Sixt <j.sixt@viscovery.net>
Date
Nov 28, 2007, 12:53 UTC
Message-ID
<474D64E7.9060603@viscovery.net>
In-Reply-To
<Pine.LNX.4.64.0711281237250.27959@racer.site>
Johannes Schindelin schrieb:
> You could still provide the "me" and unique_abbrev parameters, so that the 
> first %s in _GIT_CHERRY_PICK_HELP would be replaced by the operation, and 
> the second by the sha1.  Hmm?

Gaah! First rule to safe programming: Don't use user input as format strings. getenv(_GIT_CHERRY_PICK_HELP) *is* user input. In this case, the caller knows exactly what the put into the help string, so it should do so.

-- Hannes
Previous: Johannes Schindelin
Message 11 of 11 in “Replace misleading message during interactive rebasing”
  1. Replace misleading message during interactive rebasingWincent Colaiuta, Nov 26, 2007
  2. Johannes SixtNov 27, 2007
  3. Wincent ColaiutaNov 27, 2007
  4. Jeff KingNov 27, 2007
  5. Jakub NarebskiNov 27, 2007
  6. Jeff KingNov 27, 2007
  7. Jeff KingNov 27, 2007
  8. Junio C HamanoNov 28, 2007
  9. Wincent ColaiutaNov 28, 2007
  10. Johannes SchindelinNov 28, 2007
  11. Johannes SixtNov 28, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.