Re: [PATCH] Replace misleading message during interactive rebasing

From: Wincent Colaiuta <win@wincent.com>
Date: Nov 27, 2007, 08:49 UTC
Message-ID: <13E55438-D62B-4C92-892F-43773902E734@wincent.com>
In-Reply-To: <474BD5CA.7050407@viscovery.net>

El 27/11/2007, a las 9:31, Johannes Sixt escribió:

Show 9 quoted lines

> Wincent Colaiuta schrieb:
>> +		export _GIT_CHERRY_PICK_HELP="run 'git rebase --continue'"
>
> Isn't this a bashism? Should be:
>
> 		_GIT_CHERRY_PICK_HELP="run 'git rebase --continue'"
> 		export _GIT_CHERRY_PICK_HELP
>
> (and the second instance of this as well, of course)

I wondered that myself before submitting the patch, but then saw that the same pattern was used at other places as well:

git-clone.sh:

W=$(cd "$GIT_WORK_TREE" && pwd) && export GIT_WORK_TREE="$W"

git-filter-branch.sh:

export GIT_INDEX_FILE="$(pwd)/../index" export GIT_COMMIT=$commit export GIT_COMMIT="$sha1"

git-quiltimport.sh:

export GIT_AUTHOR_NAME=$(sed -ne 's/Author: //p' "$tmp_info") export GIT_AUTHOR_EMAIL=$(sed -ne 's/Email: //p' "$tmp_info") export GIT_AUTHOR_DATE=$(sed -ne 's/Date: //p' "$tmp_info") export SUBJECT=$(sed -ne 's/Subject: //p' "$tmp_info")

So if this is a problem, those sites will need to be changed as well.

Cheers, Wincent