Re: [PATCH] status&commit: Teach them to show submodule commit summary

From: Johannes Sixt <j.sixt@viscovery.net>
Date: Nov 12, 2007, 16:45 UTC
Message-ID: <47388344.6010008@viscovery.net>
In-Reply-To: <46dff0320711120835h31166370k64e9c92e9cf3432c@mail.gmail.com>

Ping Yin schrieb:

Show 9 quoted lines

> On Nov 12, 2007 11:59 PM, Johannes Sixt <j.sixt@viscovery.net> wrote:
> 
>> But at this time git-commit is about to be made a builtin, and since your
>> implementation contains a lot of non-portable constructs ($'', >&) and a new
>> dependency on awk (and, hence, has little chances of being accepted), I
>> suggest that you stay tuned, and implement this in the forth-coming
>> builtin-commit.c.
> Implement this in shell scripts is just a piece of cake, but not so
> easy in builtin-commit.c.

I'm with you. But git-commit.sh is a dead horse, no matter how hard you beat it.

BTW, maybe you can keep the log generation in a helper script, git-status--submodulesummary, and invoke that from builtin-commit.c. This way you get both: integration and ease of implementation.

Show 10 quoted lines

>>> A configuration variable 'submodule.status' is used to turn this summary
>>> behaviour on or off (default off). Also --submodule and --no-submodule options
>>> are added.
>> There is already 'status.color', I suggest the configuration to become
>> 'status.submoduleSummary'.
> There is 'status.color', but 'color.status' is prefered as said in the
> documentation. So i follows this rule, name the variable submodule.*
> just as the ones for git-submodule. I think it's a good idea to put
> all submodule related configuration variables in the submodule.*
> namespaces.

"I think it's a good idea to put all status related configuration variables in the status.* namespace."

But I don't care too deeply. I don't have the big picture about which configuration variables namespaces exist and which one to pick in this case.

-- Hannes