Re: [PATCH] status&commit: Teach them to show submodule commit summary

From: Johannes Sixt <j.sixt@viscovery.net>
Date: Nov 12, 2007, 15:59 UTC
Message-ID: <4738784F.7010106@viscovery.net>
In-Reply-To: <1194877277-31777-1-git-send-email-pkufranky@gmail.com>

Ping Yin schrieb:

Show 7 quoted lines

> git status/commit just treats submodules as ordinary files when reporting status
> changes. However, one may also wonder how submodules change (the commits).
> 
> This commit teaches git status/commit to additionally show commit summary of
> user-cared (i.e. checked out) modified submodules since HEAD (or HEAD^ if
> --amend option is on). For submodules deleted or initially added, commit summary
> are not shown.

In general, I like the idea (as I've already pointed out).

But at this time git-commit is about to be made a builtin, and since your implementation contains a lot of non-portable constructs ($'', >&) and a new dependency on awk (and, hence, has little chances of being accepted), I suggest that you stay tuned, and implement this in the forth-coming builtin-commit.c.

> A configuration variable 'submodule.status' is used to turn this summary
> behaviour on or off (default off). Also --submodule and --no-submodule options
> are added.

There is already 'status.color', I suggest the configuration to become 'status.submoduleSummary'.

-- Hannes