Re: [PATCH] Simplify strchrnul() compat code

From: Andreas Ericsson <ae@op5.se>
Date: Nov 10, 2007, 14:04 UTC
Message-ID: <4735BA79.5020102@op5.se>
In-Reply-To: <47359C44.6090903@lsrfire.ath.cx>

René Scharfe wrote:

>  
> -#ifdef NO_STRCHRNUL
> +#if !defined(__GLIBC__) && !__GLIBC_PREREQ(2, 1)

This will break things for users of glibc-2.1.1 (the first release still available from ftp://sources.redhat.com/pub/glibc/old-releases that includes the strchrnul() function), since __GLIBC_PREREQ() was invented after strchrnul() was introduced.

Replacing __GLIBC__ with __GLIBC_PREREQ (as in the original patch) will solve it nicely. Users of glibc-2.1.1 will be the odd minority where strchrnul() is available in their libc but not used.

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231