Re: [PATCH 1/2] Add strchrnul()

From: Jeff King <peff@peff.net>
Date: Nov 9, 2007, 03:31 UTC
Message-ID: <20071109033136.GB31760@sigill.intra.peff.net>
In-Reply-To: <4733AEA0.1060602@lsrfire.ath.cx>

On Fri, Nov 09, 2007 at 01:49:36AM +0100, René Scharfe wrote:

> As suggested by Pierre Habouzit, add strchrnul().  It's a useful GNU
> extension and can simplify string parser code.  There are several
> places in git that can be converted to strchrnul(); as a trivial
> example, this patch introduces its usage to builtin-fetch--tool.c.

Minor nit: a comment (in the code or even in the commit message) describing the what the function does would be nice. On a GNU system, one can look at the man page, but on others there is no indication of what it does except for reading the code (and maybe the answer is "this is a common library function, you idiot", but I am familiar with many GNU extensions and didn't know this one).

-Peff