Re: [PATCH] Rearrange git-format-patch synopsis to improve clarity.

From: Andreas Ericsson <ae@op5.se>
Date: Nov 5, 2007, 22:48 UTC
Message-ID: <472F9DC6.8020607@op5.se>
In-Reply-To: <ee77f5c20711051432w284cf22dx71192c145d25dced@mail.gmail.com>

David Symonds wrote:

Show 15 quoted lines

> On 11/5/07, David Symonds <dsymonds@gmail.com> wrote:
>>                     [-s | --signoff] [<common diff options>]
>> -                   [--start-number <n>] [--numbered-files]
>> +                   [-n | --numbered-files | -N | --no-numbered]
>> +                   [--start-number <n>]
> 
> Now that I look at it again, it seems the long options look quite
> inconsistent. I think it should be either
> --numbered-files/--no-numbered-files or --numbered/--no-numbered. My
> preference is with the latter (for brevity), but that breaks
> backward-compatibility.
> 
> Would you accept a patch that changed --numbered-files to --numbered,
> and kept the former as a synonym?
>

I thought files were always numbered, but the [PATCH m/n] wasn't. Have I missed something?

If your --numbered-files is supposed to affect only file-numbering, I'd suggest *not* using --numbered, as it's ambiguous with "number-subject".

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231