Re: [PATCH] git-format-patch: Don't number patches when there's only one

From: Andreas Ericsson <ae@op5.se>
Date: Oct 22, 2007, 10:14 UTC
Message-ID: <471C77F0.5050701@op5.se>
In-Reply-To: <Pine.LNX.4.64.0710221044080.25221@racer.site>

Johannes Schindelin wrote:

Show 8 quoted lines

> Hi,
> 
> On Sun, 21 Oct 2007, Andreas Ericsson wrote:
> 
>> [PATCH 1/1] looks a bit silly, and automagically handling this in 
>> git-format-patch makes some scripting around it a lot more pleasant.
> 
> I think you should not use "-n" if you do not want to have the numbers.

This stems from creating scripts around it where I only want to see the numbers if there is more than a single patch. Currently I can't do that without running git-format-patch twice or re-implementing the revision parsing machinery to count revisions prior to passing arguments to format-patch.

Show 5 quoted lines

> In circumstances as yours, where you can have patch series larger than 
> one, I imagine that the "[PATCH 1/1]" bears an important information, 
> which is not present in "[PATCH]": this patch series contains only one 
> patch.
>

That's sort of implicit in [PATCH], since all patch-series added by the tool I'm scripting will have [PATCH n/m], while I'd prefer for single-patches to have only [PATCH].

> IOW I do not like your patch: too much DWIDNS (Do What I Did NOT Say) for 
> me.
>

Would a separate option be acceptable to you?

It doesn't have to be fancy or short, since I really only mean to use it from our scripts.

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231