Re: [PATCHv2 1/5] Add a generic tree traversal to fetch SVN properties.

From: Johannes Sixt <j.sixt@viscovery.net>
Date: Oct 16, 2007, 14:53 UTC
Message-ID: <4714D068.8090606@viscovery.net>
In-Reply-To: <1192545412-10929-1-git-send-email-tsuna@lrde.epita.fr>

Benoit Sigoure schrieb:

> 	* git-svn.perl (&traverse_ignore): Remove.
> 	(&prop_walk): New.
> 	(&cmd_show_ignore): Use prop_walk.

This may be your favorite style of commit messaged, but I think the concensus for git is a different style of commit message: We would like to see *why* this change is good. But you only note *what* was changed, something that can be seen by looking at the patch anyway.

The commit message should be helpful when the commit is looked at in isolation, like when you are doing some code archeology half a year later and e.g. git-blame/git-bisect points you to this commit.

Also a notice such as

  "With this we will be able to lift properties like svn:ignore into
   .gitignore in a follow-up change."

tells that this was actually part of a series and you don't have to remember that half a year ago there were 4 more patches submitted in the same second with this one.

-- Hannes