git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv2 1/5] Add a generic tree traversal to fetch SVN properties.

From
Benoit SIGOURE <tsuna@lrde.epita.fr>
Date
Oct 16, 2007, 15:10 UTC
Message-ID
<0D1ADA80-223C-4143-BCEC-5275E0EAD357@lrde.epita.fr>
In-Reply-To
<4714D068.8090606@viscovery.net>
On Oct 16, 2007, at 4:53 PM, Johannes Sixt wrote:
Show 22 quoted lines
> Benoit Sigoure schrieb:
>> 	* git-svn.perl (&traverse_ignore): Remove.
>> 	(&prop_walk): New.
>> 	(&cmd_show_ignore): Use prop_walk.
>
> This may be your favorite style of commit messaged, but I think the  
> concensus for git is a different style of commit message: We would  
> like to see *why* this change is good. But you only note *what* was  
> changed, something that can be seen by looking at the patch anyway.
>
> The commit message should be helpful when the commit is looked at  
> in isolation, like when you are doing some code archeology half a  
> year later and e.g. git-blame/git-bisect points you to this commit.
>
> Also a notice such as
>
>  "With this we will be able to lift properties like svn:ignore into
>   .gitignore in a follow-up change."
>
> tells that this was actually part of a series and you don't have to  
> remember that half a year ago there were 4 more patches submitted  
> in the same second with this one.
Indeed, sorry, I'll write more explanatory commit messages next time :)
-- 
Benoit Sigoure aka Tsuna
EPITA Research and Development Laboratory
Previous: Johannes Sixt
Message 8 of 8 in “[PATCHv2 1/5] Add a generic tree traversal to fetch SVN properties.”
  1. Benoit SigoureOct 16, 2007
  2. 2/5 Implement git svn create-ignore.Benoit Sigoure, Oct 16, 2007
  3. 3/5 Add git svn propget.Benoit Sigoure, Oct 16, 2007
  4. 4/5 Add git svn proplist.Benoit Sigoure, Oct 16, 2007
  5. 5/5 Simplify the handling of fatal errors.Benoit Sigoure, Oct 16, 2007
  6. git-svn: Document the `create-ignore', `propget' and `proplist' subcommands.Benoit Sigoure, Nov 12, 2007
  7. Johannes SixtOct 16, 2007
  8. Benoit SIGOUREOct 16, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.