Re: [PATCH] status&commit: Teach them to show commits of modified submodules.

From: Yin Ping <pkufranky@gmail.com>
Date: Nov 11, 2007, 05:30 UTC
Message-ID: <46dff0320711102130g5171a421r244bdf74a578f68b@mail.gmail.com>
In-Reply-To: <20071110195509.GI2261MdfPADPa@greensroom.kotnet.org>

On Nov 11, 2007 3:55 AM, Sven Verdoolaege <skimo@kotnet.org> wrote:

Show 6 quoted lines

> On Sun, Nov 11, 2007 at 03:27:43AM +0800, Ping Yin wrote:
> > This commit teaches git status/commit to also show commits of user-cared
>
> Does it?  It looks like you only changed git-commit.
> Shouldn't this be put in wt_status_print, if anywhere?
>

git-commit and git-status correspond to the same script git-commit.sh

Show 8 quoted lines

> Also, you have some typos:
>
> > +     test -n "$modules" && echo -e "#\n# submodule modifiled: "$modules"\n#"
> [..]
> > +                             echo "  Warn: $name dosn't contains commit $headone"
>
> skimo
>

Oops, i'll fix it

-- 
Ping Yin