git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] cvsserver: Fix req_update to handle packed refs

From
Martin Langhoff <martin.langhoff@gmail.com>
Date
Oct 4, 2007, 20:43 UTC
Message-ID
<46a038f90710041343g5b6a5a30gcd0c9f18d265fa28@mail.gmail.com>
In-Reply-To
<1191525680-10481-1-git-send-email-frank@lichtenheld.de>
On 10/5/07, Frank Lichtenheld <frank@lichtenheld.de> wrote:
Show 7 quoted lines
> cvsserver returns a list of existing modules on command
> 'update' without a module specified (apparently this is
> used by some clients to get a list of available modules,
> the CVS cli client doesn't support it).
>
> Fix this code to work correctly in presence of packed refs.
> (Use git-branch instead of reading refs/heads/)
ACK - good stuff - thanks!

There is one minor issue around this I suspect - refs with slashes in them. Without this patch, only refs that literally sit in refs/heads will be returned. With git branches, you could see oldbranches/foo being returned to the client.

IIRC - the behaviour cvsserver supports here is completely unspecified, and clients will probably error out in weird and wacky ways. I'd perhaps filter out any headref with a slash.

cheers,
martin
Previous: Frank LichtenheldNext: Frank Lichtenheld
Message 2 of 3 in “cvsserver: Fix req_update to handle packed refs”
  1. cvsserver: Fix req_update to handle packed refsFrank Lichtenheld, Oct 4, 2007
  2. Martin LanghoffOct 4, 2007
  3. Frank LichtenheldOct 4, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.