From: Martin Langhoff <martin.langhoff@gmail.com>
Date: Thu, 04 Oct 2007 20:43:55 GMT
Subject: Re: [PATCH] cvsserver: Fix req_update to handle packed refs
Message-ID: <46a038f90710041343g5b6a5a30gcd0c9f18d265fa28@mail.gmail.com>
In-Reply-To: <1191525680-10481-1-git-send-email-frank@lichtenheld.de>

On 10/5/07, Frank Lichtenheld <frank@lichtenheld.de> wrote:
> cvsserver returns a list of existing modules on command
> 'update' without a module specified (apparently this is
> used by some clients to get a list of available modules,
> the CVS cli client doesn't support it).
>
> Fix this code to work correctly in presence of packed refs.
> (Use git-branch instead of reading refs/heads/)

ACK - good stuff - thanks!

There is one minor issue around this I suspect - refs with slashes in
them. Without this patch, only refs that literally sit in refs/heads
will be returned. With git branches, you could see oldbranches/foo
being returned to the client.

IIRC - the behaviour cvsserver supports here is completely
unspecified, and clients will probably error out in weird and wacky
ways. I'd perhaps filter out any headref with a slash.

cheers,


martin