git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-gui: Handle git versions of the form n.n.n.GIT

From
Martin Langhoff <martin.langhoff@gmail.com>
Date
Jul 18, 2007, 02:32 UTC
Message-ID
<46a038f90707171932m67c51388jb2304f0b1873e3a6@mail.gmail.com>
In-Reply-To
<20070718015138.GR32566@spearce.org>
On 7/17/07, Shawn O. Pearce <spearce@spearce.org> wrote:
>   Applying git-gui: Handle git versions of the form n.n.n.GIT
>

I'm far from an authority on things TCL, but I don't think this patch should be merged as is. Julian is reporting it as a "fixes my symptom" patch, and that's barely what it does.

The regex should be more liberal, imho. With this superficial fix:
 - Builds from a dirty tree have a broken git gui
 - Builds from a repo with a nonstandard (local) tagname tagname  have
a broken git gui
cheers,
martin
Previous: Shawn O. PearceNext: Shawn O. Pearce
Message 11 of 13 in “Problem running git-gui”
  1. Julian PhillipsJul 17, 2007
  2. Thomas GlanzmannJul 17, 2007
  3. git-gui: Handle git versions of the form n.n.n.GITJulian Phillips, Jul 17, 2007
  4. Brian DowningJul 17, 2007
  5. Brian DowningJul 17, 2007
  6. Jason SewallJul 17, 2007
  7. Shawn O. PearceJul 18, 2007
  8. Linus TorvaldsJul 17, 2007
  9. Shawn O. PearceJul 18, 2007
  10. Shawn O. PearceJul 18, 2007
  11. Martin LanghoffJul 18, 2007
  12. Shawn O. PearceJul 18, 2007
  13. Julian PhillipsJul 18, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.