From: Martin Langhoff <martin.langhoff@gmail.com>
Date: Wed, 18 Jul 2007 02:32:50 GMT
Subject: Re: [PATCH] git-gui: Handle git versions of the form n.n.n.GIT
Message-ID: <46a038f90707171932m67c51388jb2304f0b1873e3a6@mail.gmail.com>
In-Reply-To: <20070718015138.GR32566@spearce.org>

On 7/17/07, Shawn O. Pearce <spearce@spearce.org> wrote:
>   Applying git-gui: Handle git versions of the form n.n.n.GIT
>

I'm far from an authority on things TCL, but I don't think this patch
should be merged as is. Julian is reporting it as a "fixes my symptom"
patch, and that's barely what it does.

The regex should be more liberal, imho. With this superficial fix:

 - Builds from a dirty tree have a broken git gui

 - Builds from a repo with a nonstandard (local) tagname tagname  have
a broken git gui

cheers,


martin