Re: [PATCH] rebase -i: commit when continuing after "edit"

From: Johannes Sixt <j.sixt@viscovery.net>
Date: Sep 25, 2007, 14:17 UTC
Message-ID: <46F91879.6030301@viscovery.net>
In-Reply-To: <Pine.LNX.4.64.0709251439070.28395@racer.site>

Johannes Schindelin schrieb:

Show 20 quoted lines

> Hi,
> 
> On Tue, 25 Sep 2007, Johannes Sixt wrote:
>> How about:
>>
>> 	eval "$author_script"
>> 	GIT_AUTHOR_NAME="$GIT_AUTHOR_NAME" \
>> 	GIT_AUTHOR_EMAIL="$GIT_AUTHOR_EMAIL" \
>> 	GIT_AUTHOR_DATE="$GIT_AUTHOR_DATE" \
>> 	$USE_OUTPUT git commit -F "$MSG" $EDIT_COMMIT
>>
>> and if you dislike that, put the two questionable lines in parenthesis.
> 
> That looks ugly.  I'd rather have something like
> 
> 	eval "$USE_OUTPUT $author_script git commit -F \"$MSG\" $EDIT_COMMIT"
> 
> but I'm not quite certain if that is enough, what with the funny 
> characters people put into path names these days ($MSG points to 
> "$DOTEST"/message).

I, too, find it ugly, but I think it's the most readable way to do it. Your version is certainly underquoted.

I poked around a bit, but one major obstacle is that the assignments in $author_script are on separate lines, which you would have to splice into a single line before you can insert them in the eval.

-- Hannes