Re: [PATCH] Make "git reset" a builtin. (incomplete)
- From
Andreas Ericsson <ae@op5.se>
- Date
- Aug 22, 2007, 13:37 UTC
- Message-ID
- <46CC3C17.8040901@op5.se>
- In-Reply-To
- <86absjenc3.fsf@lola.quinscape.zz>
David Kastrup wrote:
Show 12 quoted lines
> Carlos Rica <jasampler@gmail.com> writes: > >> This is the first version of the program "builtin-reset.c", >> intended for replacing the script "git-reset.sh". >> >> The --mixed option with -- paths is not implemented yet. >> >> The tests I made for it are not finished so they are not included, >> but it seems to pass the rest of the test suite. > > Could you be so kind as to give a one-sentence summary what the > benefits over using a shell script would be?
One word: Portability.
There's a plethora of various shell syntaxes. Discerning what's correct shell and what's a bash'ism that may or may not be posixly correct (but perhaps not supported on a multitude of out-of-the-box solaris system) has so far taken almost as much time as convincing newcomers to git that there really is no point in tracking file renames explicitly.
Otoh, the list of large and renowned projects that have shunned git for its weak windows support grows longer, meaning we potentially lose competent programmers simply because they're forced to use something else.
Show 5 quoted lines
> I think this work has > started before I joined the list, and I'd be interested in the > motivation for it. In general, I find shell scripts more pleasant for > hacking on than C code, and there is no long-term plan to replace all > of them, is there?
There is, but nobody is putting a full-time effort into it, so the change is gradual and happens one program at a time whenever someone sends in a well-written C-program to replace a shell-script. Normally the C-program has to either show tremendous speed improvements or retain all functionality of the shell-script in order to be accepted.
Show 5 quoted lines
> So unless there is some issue that can't be > addressed reliably or efficiently by reverting to other commands for > everything involving bulk processing, I am not really happy to see > shell scripts replaced. >
It will happen, sooner or later. We may not like MS or their products, but sooner or later we'll have to cater to their users or face the problem of all the competent programmers helping out on some other SCM, because that other SCM works everywhere, while git doesn't.
-- Andreas Ericsson andreas.ericsson@op5.se OP5 AB www.op5.se Tel: +46 8-230225 Fax: +46 8-230231