git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] builtin-bundle create - use lock_file

From
Mark Levedahl <mdl123@verizon.net>
Date
Aug 12, 2007, 18:22 UTC
Message-ID
<46BF4FFF.1090309@verizon.net>
In-Reply-To
<7v1we8k5qx.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano wrote:
Show 10 quoted lines
> When you exit before committing lockfiles
> you hold, atexit handler rolls back and unlink them for you.
>
> The following might be a better replacement.
>
> By the way, by using lockfile's "create temporary, generate into
> it and then rename to final", we are allowing an overwrite of an
> existing bundle, which we did not allow earlier.  Is this check
> something we would want to preserve?
>

Ack - yours is much better. Thanks for the lesson. Also, the former behavior of not allowing overwrite of an existing file was (at least in my opinion) very un-git'ish so I am happy to see that go.

Mark
Previous: Junio C Hamano
Message 4 of 4 in “builtin-bundle create - use lock_file semantics”
  1. builtin-bundle create - use lock_file semanticsMark Levedahl, Aug 12, 2007
  2. builtin-bundle create - use lock_fileMark Levedahl, Aug 12, 2007
  3. Junio C HamanoAug 12, 2007
  4. Mark LevedahlAug 12, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.