From: Mark Levedahl <mdl123@verizon.net>
Date: Sun, 12 Aug 2007 18:22:55 GMT
Subject: Re: [PATCH] builtin-bundle create - use lock_file
Message-ID: <46BF4FFF.1090309@verizon.net>
In-Reply-To: <7v1we8k5qx.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano wrote:
> When you exit before committing lockfiles
> you hold, atexit handler rolls back and unlink them for you.
>
> The following might be a better replacement.
>
> By the way, by using lockfile's "create temporary, generate into
> it and then rename to final", we are allowing an overwrite of an
> existing bundle, which we did not allow earlier.  Is this check
> something we would want to preserve?
>   
Ack - yours is much better. Thanks for the lesson. Also, the former 
behavior of not allowing overwrite of an existing file was (at least in 
my opinion) very un-git'ish so I am happy to see that go.

Mark