git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] git-submodule: move cloning into a separate function

From
Johannes Sixt <j.sixt@eudaptics.com>
Date
Jun 5, 2007, 10:40 UTC
Message-ID
<46653DB2.997A3ABD@eudaptics.com>
In-Reply-To
<11810357522478-git-send-email-hjemli@gmail.com>
Lars Hjemli wrote:
> +               module_clone "$path" "$url" || exit $?

Minor nit: The idiom that is commonly used in situations like this (see other git-* shell scripts):

		module_clone "$path" "$url" || exit

because exit without argument uses the code of the last command executed.

-- Hannes
Previous: Lars HjemliNext: Lars Hjemli
Message 3 of 11 in “git-submodule: make it easier to use alternate urls”
  1. 0/2 git-submodule: make it easier to use alternate urlsLars Hjemli, Jun 5, 2007
  2. 1/2 git-submodule: move cloning into a separate functionLars Hjemli, Jun 5, 2007
  3. Johannes SixtJun 5, 2007
  4. 1/2 git-submodule: move cloning into a separate functionLars Hjemli, Jun 5, 2007
  5. Junio C HamanoJun 6, 2007
  6. 1/2 git-submodule: move cloning into a separate functionLars Hjemli, Jun 6, 2007
  7. 2/2 git-submodule: clone during update, not during initLars Hjemli, Jun 6, 2007
  8. Sven VerdoolaegeJun 17, 2007
  9. Lars HjemliJun 17, 2007
  10. 2/2 git-submodule: clone during update, not during initLars Hjemli, Jun 5, 2007
  11. 2/2 git-submodule: clone during update, not during initLars Hjemli, Jun 5, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.